Skip to content

fix(backfill): create issue rows before PR metadata jobs #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JSONbored wants to merge 1 commit into
base: test
Choose a base branch
from
Open

fix(backfill): create issue rows before PR metadata jobs #95

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions packages/das/src/queue/fetch.processor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,10 @@ export class FetchProcessor extends WorkerHost {
);
this.logger.log(`Backfilled ${prs.length} PRs from ${repoFullName}`);

// Fetch and upsert issues before PR metadata jobs can link solved_by_pr.
await this.fetcher.backfillIssues(repoFullName, sinceDate);
this.logger.log(`Backfilled issues from ${repoFullName}`);

// Enqueue follow-up jobs (metadata + files for every PR).
for (const { prNumber, headSha, baseSha } of prs) {
await this.fetchQueue.add(
Expand All @@ -160,10 +164,6 @@ export class FetchProcessor extends WorkerHost {
baseSha ?? null,
);
}

// Fetch and upsert issues
await this.fetcher.backfillIssues(repoFullName, sinceDate);
this.logger.log(`Backfilled issues from ${repoFullName}`);
}

private async handleStalePrFilesJob(
Expand Down