Skip to content

fix(webhook): requeue failed PR metadata jobs #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
volcano303 wants to merge 1 commit into from
Closed

fix(webhook): requeue failed PR metadata jobs #76

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion packages/das/src/webhook/handlers/pull-request.handler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,12 +68,13 @@ export class PullRequestHandler {
];
if (metadataActions.includes(action)) {
const jobId = `meta-${repoFullName}-${prNumber}`;
await this.removeRetainedFailedMetadataJob(jobId);
await this.fetchQueue.add(
FETCH_JOBS.PR_METADATA,
{ repoFullName, prNumber },
{
jobId,
// Replace any pending job for the same PR (e.g. rapid pushes)
// Deduplicate pending/active jobs for the same PR.
removeOnComplete: true,
removeOnFail: 50,
attempts: 3,
Expand Down Expand Up @@ -117,4 +118,17 @@ export class PullRequestHandler {
);
}
}

private async removeRetainedFailedMetadataJob(jobId: string): Promise<void> {
const existingJob = await this.fetchQueue.getJob(jobId);
if (!existingJob) return;

const state = await existingJob.getState();
if (state !== "failed") return;

await existingJob.remove();
this.logger.warn(
`Removed retained failed PR metadata job ${jobId} before requeueing`,
);
}
}