fix(webhook): refresh PR files on pull_request.edited base retarget (#62)#115
Open
jeffrey701 wants to merge 1 commit into
Open
fix(webhook): refresh PR files on pull_request.edited base retarget (#62)#115jeffrey701 wants to merge 1 commit into
jeffrey701 wants to merge 1 commit into
Conversation
…ntrius#62) The handler enqueues PR_FILES on opened / synchronize / merged-closed but not on pull_request.edited with a base-ref change. The PR row updates its baseSha, but the stored pr_files and scoringDataStored stay pinned to the old base — leaving scoring inputs stale. Detect a base retarget via payload.changes.base, clear scoringDataStored, and enqueue PR_FILES with the new base/head SHAs through the existing prFilesJobId path. Closes entrius#62
Collaborator
|
Duplicate of #64 which is better scoped/implemented. Closing. |
10 tasks
Collaborator
Collaborator
|
fix CI |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pull-request file scoring data is refreshed on
opened,synchronize, and mergedclosedevents but not onpull_request.edited. When a PR's base branch is retargeted, GitHub sendseditedwith achanges.baseblock; the row'sbaseShais updated, butpr_filesandscoringDataStoredstay pinned to the old base.Treat the
changes.baseform ofeditedas another refresh trigger: clearscoringDataStoredand enqueue the samePR_FILESjob used for normal refreshes (with the new base/head SHAs).Related Issues
Closes #62
Type of Change
Testing
prFilesJobIdjob andscoringDataStoredflag.Checklist