Do not pin golang version in CI.#4
Merged
Merged
Conversation
Without --yes the plugin prompts, hits EOF on CI stdin, and aborts, so no smoke job performed an upgrade — they passed vacuously. Pass --yes so the upgrade runs, and add `set -o pipefail` (bash) / a $LASTEXITCODE guard (pwsh) so a failed upgrade fails the step instead of being swallowed by the `tee` pipeline. Expected to fail on the go-install jobs: `go install`ing the latest cli needs the Go version in its go.mod (1.26.3), above the runner's pinned 1.26.2. Unpinning is a separate change. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Entire-Checkpoint: 67a06b45a991
Entire-Checkpoint: ab17fa70cf8a
This reverts commit d1fbb50.
setup-go exports GOTOOLCHAIN=local, which blocks `go install` from fetching the newer toolchain the latest cli's go.mod requires. Override it to auto on the two go-install Exercise steps so the upgrade tracks cli's climbing Go floor instead of failing on a pinned toolchain. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Entire-Checkpoint: da89d3c6f140
toothbrush
marked this pull request as ready for review
June 4, 2026 01:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
There's a latent time bomb for whoever is unlucky to touch this repo last. We have version pinning that can drift between here and entireio/cli.
https://github.com/entireio/cli/blob/1db011c007fe0c82d60a0d497da416da702906c7/go.mod#L3 now pins 1.26.4, whereas our CI pins something older. No point. Just remove and let the very capable Golang toolchain handle it.
In 906b17d we see a failure, because there's a version mismatch. This is because CLI effectively drifted from this repo. Boo. Let's make it automatic.
Also
actions/setup-gohas surprising defaults, so it took me a few tries to get it to work as i wanted.Note
Cursor Bugbot is generating a summary for commit b1abf1d. Configure here.