Slight cosmetic tweaks to output#1343
Open
toothbrush wants to merge 5 commits into
Open
Conversation
I found the "Press Enter to..." prompt got a bit lost and i always had to double-take. Tried to neaten it a tiny bit.
I like seeing what has been installed. Makes me less nervous.
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request makes small, user-facing output tweaks in the CLI to improve readability during the login device-flow, and adjusts a local dev publish task to print what it installed.
Changes:
- Update
mise run dev:publishto installentireandgit-remote-entirein a loop and emit an “Installed:” line. - Refine
entire loginoutput formatting (URL labeling/spacing, single-line “waiting → success” flow). - Adjust success/waiting strings in the login flow output.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
mise-tasks/dev/publish |
Installs binaries one-by-one and prints an install confirmation per command. |
cmd/entire/cli/login.go |
Tweaks device-login UX output (URL labeling, prompt formatting, waiting/success line behavior). |
Comments suppressed due to low confidence (1)
cmd/entire/cli/login.go:103
- Because "Waiting for approval..." is now written without a newline, any later error printed by main.go (to stderr) can end up on the same terminal line as the waiting message, making failure output hard to read. Adding a newline before returning the error keeps the single-line success output while preserving readable failures.
if err != nil {
return fmt.Errorf("complete login: %w", err)
}
Match the renamed "Login URL:" prefix and lowercase "login complete." strings from the cosmetic login output tweak. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Entire-Checkpoint: bb20852cb016
Contributor
Author
|
@cursor review |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 7fdfa6b. Configure here.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Entire-Checkpoint: f8442932682e
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://entire.io/gh/entireio/cli/trails/496
Description
Very small prettification of things that were bothering me:
mise run dev:publish- i use it all the time and i like it when it tells me what it's installedNote
Low Risk
User-facing copy and test assertions only; no auth, token, or polling logic changes.
Overview
Polishes
entire loginCLI output so the device code, login URL, and Enter prompt are easier to scan: renames Approval URL to a labeledLogin URL:line (with spacing), shortens the interactive Press Enter text, prints Waiting for approval... on the same line as the success marker, and ends with✅ login complete.(lowercase). Integration tests now assert the new strings and parseLogin URL:instead ofApproval URL:.mise run dev:publishinstallsentireandgit-remote-entirein a loop and prints an Installed: line per binary to stderr.Reviewed by Cursor Bugbot for commit 7fdfa6b. Configure here.