[server] Add workaround for intermittent Safari CORS errors #4540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At times, Safari will fail our API responses because its CORS preflight fails. The errors are reproducible, but intermittently, and not on localhost. We seem not to be the first ones to hit [this](processing/p5.js-web-editor#3156). Based on a hint from: supabase/supabase#20982 (comment) Modify our CORS responses to use 200 instead of 204 to try and fix Safari.
ua741
approved these changes
Dec 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At times, Safari will fail our API responses because its CORS preflight fails. The errors are reproducible, but intermittently, and not on localhost. We seem not to be the first ones to hit this.
Based on a hint from:
supabase/supabase#20982 (comment)
Modify our CORS responses to use 200 instead of 204 to try and fix Safari.