Skip to content

setup.py: use open instead of file #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: multi-protocol
Choose a base branch
from
Open

setup.py: use open instead of file #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
08a8cb9
setup.py: use open instead of file
Sep 4, 2024
2352845
setup.py: add modem/protocol in packages
Sep 4, 2024
9879cdf
zmodem: add more logging
Sep 4, 2024
6e887ae
base: called crc functions already iterate the input
Sep 4, 2024
65b779a
crc32: use already available CRC32_map instead of zlib
Sep 5, 2024
5f62acc
split-me
Sep 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
tests:
PYTHONPATH=. python test/test.py test/test.py
PYTHONPATH=. python test/test-recv.py
PYTHONPATH=. python test/test-send.py
# PYTHONPATH=. python test/test-send.py
# PYTHONPATH=. python test/test.py test/test.py

upload:
python setup.py sdist upload
Expand Down
6 changes: 2 additions & 4 deletions modem/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,7 @@ def calc_crc16(self, data, crc=0):
'0xd5e3'

'''
for byte in data:
crc = crc16(byte, crc)
crc = crc16(data, crc)
return crc

def calc_crc32(self, data, crc=0):
Expand All @@ -49,8 +48,7 @@ def calc_crc32(self, data, crc=0):
'0x20ad'

'''
for byte in data:
crc = crc32(byte, crc)
crc = crc32(data, crc)
return crc

def _check_crc(self, data, crc_mode):
Expand Down
1 change: 0 additions & 1 deletion modem/const.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -289,7 +289,6 @@
CAN = b'\x18'
CRC = b'\x43'

TIMEOUT = None
ZPAD = 0x2a
ZDLE = 0x18
ZDLEE = 0x58
Expand Down
Loading