Skip to content

Commit

Permalink
Disable temporarily build of build-kit-everest-core image (EVerest#866)
Browse files Browse the repository at this point in the history
Disable temporarily build of build-kit-everest-core image

Use build-kit-base instead. Since github doesn't pass secrets to ci runs
in forks the current workflow technically doesn't work for forks. To
provide a quick solution the feature of modifying the build-kit-base
image is disabled.

Signed-off-by: Andreas Heinrich <[email protected]>
  • Loading branch information
andistorm authored Sep 12, 2024
1 parent dd51ef0 commit 9780450
Showing 1 changed file with 12 additions and 4 deletions.
16 changes: 12 additions & 4 deletions .github/workflows/build_and_test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,8 @@ jobs:

# Since env variables can't be passed to reusable workflows, we need to pass them as outputs
setup-env:
# This job is currently disabled to allow running ci on PRs from forks
if: false
name: Setup Environment
runs-on: ${{ inputs.runner || 'ubuntu-22.04' }}
outputs:
Expand All @@ -46,6 +48,8 @@ jobs:
run: |
echo "Setting up environment"
build-and-push-build-kit:
# This job is currently disabled to allow running ci on PRs from forks
if: false
name: Build and Push Build Kit
uses: everest/everest-ci/.github/workflows/[email protected]
needs: setup-env
Expand All @@ -67,10 +71,12 @@ jobs:
build:
name: Build and Unit Tests
needs: build-and-push-build-kit
# needs: build-and-push-build-kit
runs-on: ${{ inputs.runner || 'ubuntu-22.04' }}
env:
BUILD_KIT_IMAGE: ${{ needs.build-and-push-build-kit.outputs.one_image_tag_long }}
# Currently the build-kit-base image is used to allow running ci on PRs from forks
# BUILD_KIT_IMAGE: ${{ needs.build-and-push-build-kit.outputs.one_image_tag_long }}
BUILD_KIT_IMAGE: ghcr.io/everest/everest-ci/build-kit-base:v1.3.1
steps:
- name: Format branch name for cache key
run: |
Expand Down Expand Up @@ -140,9 +146,11 @@ jobs:
name: Integration Tests
needs:
- build
- build-and-push-build-kit
# - build-and-push-build-kit
env:
BUILD_KIT_IMAGE: ${{ needs.build-and-push-build-kit.outputs.one_image_tag_long }}
# Currently the build-kit-base image is used to allow running ci on PRs from forks
# BUILD_KIT_IMAGE: ${{ needs.build-and-push-build-kit.outputs.one_image_tag_long }}
BUILD_KIT_IMAGE: ghcr.io/everest/everest-ci/build-kit-base:v1.3.1
runs-on: ${{ inputs.runner || 'ubuntu-22.04' }}
steps:
- name: Download dist dir
Expand Down

0 comments on commit 9780450

Please sign in to comment.