Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[oneplus] Add OnePlus devices #3796

Merged
merged 4 commits into from
Jul 21, 2024
Merged

[oneplus] Add OnePlus devices #3796

merged 4 commits into from
Jul 21, 2024

Conversation

paulverbeke
Copy link
Contributor

Since the only "official" updates policy is a community post here https://community.oneplus.com/thread/1462181 (and here for the old one https://community.oneplus.com/thread/862347) should this be considered enough to start a PR for OnePlus devices ?
And since these are only promises should I display the exact calculated date or just yes ?
For instance for the active support they don't say X years of support but X major Android updates ? Should I translate these 4 major Android updates to 4 years ?

@marcwrobel
Copy link
Member

marcwrobel commented Oct 15, 2023 •
edited
Loading

Since the only "official" updates policy is a community post here https://community.oneplus.com/thread/1462181 (and here for the old one https://community.oneplus.com/thread/862347) should this be considered enough to start a PR for OnePlus devices ?

Sure ! But you must also commit to maintain this page over time. Information don't have to be precise or even up-to-date, but on the other hand it must not be completely outdated.

And since these are only promises should I display the exact calculated date or just yes ?

I would say "yes/no" for now, that would make things easier for a start.

One thing I consider very important is to document as much as possible the dates (using comments in the yaml) with:

  • link(s) to the website(s) that document the dates
  • approximated date if it makes sense
  • ...
    Without that information it makes it very difficult for reviewers to validate the changes.

And for the link attribute prefer using the support site (such as https://service.oneplus.com/us/search/search-detail?id=2123192&articleIndex=2) than the "marketing" site (such as https://www.oneplus.in/11r). Link to support sites have less chances to change over time.

@marcwrobel marcwrobel added the new-product This PR adds a new product to the website. label Oct 20, 2023
@paulverbeke paulverbeke force-pushed the add-oneplus branch 3 times, most recently from 0aa7784 to ebc3edc Compare November 29, 2023 14:33
@paulverbeke paulverbeke force-pushed the add-oneplus branch 2 times, most recently from f8bafd7 to b6bea92 Compare December 28, 2023 00:50
@paulverbeke paulverbeke force-pushed the add-oneplus branch 6 times, most recently from 1dbaa30 to 6a812c1 Compare January 6, 2024 01:07
@paulverbeke paulverbeke changed the title WIP [oneplus] Add OnePlus devices [oneplus] Add OnePlus devices Jan 6, 2024
@paulverbeke
Copy link
Contributor Author

@marcwrobel finished a first draft with the last 3 devices released. I documented as thoroughly as I could and searched a lot for the most reliable links I could find. Let me know what you think. Once we agree on the format and content we can push this and I'll work on a new PR for other devices

@paulverbeke paulverbeke marked this pull request as ready for review January 6, 2024 01:12
marcwrobel
marcwrobel requested changes Jan 20, 2024
View reviewed changes
products/oneplus.md Outdated Show resolved Hide resolved
products/oneplus.md Outdated Show resolved Hide resolved
products/oneplus.md Outdated Show resolved Hide resolved
products/oneplus.md Outdated Show resolved Hide resolved
products/oneplus.md Outdated Show resolved Hide resolved
products/oneplus.md Outdated Show resolved Hide resolved
products/oneplus.md Outdated Show resolved Hide resolved
products/oneplus.md Outdated Show resolved Hide resolved
products/oneplus.md Outdated Show resolved Hide resolved
products/oneplus.md Outdated Show resolved Hide resolved
@marcwrobel
Copy link
Member

@marcwrobel finished a first draft with the last 3 devices released. I documented as thoroughly as I could and searched a lot for the most reliable links I could find. Let me know what you think. Once we agree on the format and content we can push this and I'll work on a new PR for other devices

Thanks @paulverbeke, good idea to start with only a few phones to make it easier to review.

Overall that's a good start but I think there is too much information in the description. I think a shorter description focusing on just the current release / support / EOL policies would be best. Historical/outdated policies can be briefly mentioned but should not be described in details.

@paulverbeke paulverbeke force-pushed the add-oneplus branch 2 times, most recently from 54f17ec to b316649 Compare April 2, 2024 01:43
@paulverbeke
Copy link
Contributor Author

@marcwrobel I've made a new batch with most of the requested changes. Let me know what you think

captn3m0
captn3m0 reviewed Apr 15, 2024
View reviewed changes
products/oneplus.md Outdated Show resolved Hide resolved
@captn3m0
[oneplus] Minor changes
738d01d 
- removed comments, we can track TODO elsewhere.
- Dropped "chinese" mention. We only use this in one other place (Motorola), will drop from there as well.
@captn3m0
Copy link
Member

captn3m0 commented Apr 27, 2024 •
edited
Loading

Moving the list of remaining devices to this comment, we can create a new issue to track this after this is merged.

TODO Devices:

3 major android updates and 4 years of security updates

2 major android updates and 3 years of security updates:

  • OnePlus 7 Pro
  • OnePlus 7T Pro
  • OnePlus 7T
  • OnePlus 7
  • OnePlus 6T
  • OnePlus 6
  • OnePlus 5T
  • OnePlus 5
  • OnePlus 3T
  • OnePlus 3

2 major android updates and 3 years of security updates

  • OnePlus Nord CE 3 Lite
  • OnePlus Nord CE 3
  • OnePlus Nord 2T
  • OnePlus Nord CE 2 Lite
  • OnePlus Nord CE 2
  • OnePlus Nord 2
  • OnePlus Nord CE
  • OnePlus Nord

1 major android update and 3 years of security updates

  • OnePlus Nord N30 SE
  • OnePlus Nord N30
  • OnePlus Nord N300
  • OnePlus Nord N20 SE
  • OnePlus Nord N20
  • OnePlus Nord N200
  • OnePlus Nord N100
  • OnePlus Nord N10

@paulverbeke @marcwrobel
Update products/oneplus.md
12ef0f1 
Co-authored-by: Marc Wrobel <[email protected]>
@paulverbeke
Copy link
Contributor Author

paulverbeke commented May 8, 2024 •
edited
Loading

all right, I've resolved all the conv and made requested changes. Thanks a lot both of you for your time. Needs only for you to settle on a title now !
EDIT: resolved the title too !

@paulverbeke paulverbeke requested a review from marcwrobel June 3, 2024 07:22
@paulverbeke
Copy link
Contributor Author

@marcwrobel is something missing/preventing this PR from going forward ?
Thanks

marcwrobel
marcwrobel approved these changes Jul 21, 2024
View reviewed changes
Copy link
Member

@marcwrobel marcwrobel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot for this contribution (and your patience !).

@marcwrobel
Copy link
Member

@marcwrobel is something missing/preventing this PR from going forward ?

Nothing, I am a bit less active on endoflife.date these days and just missed your updates. Thanks for the reminder.

@marcwrobel marcwrobel merged commit fbd9ac7 into endoflife-date:master Jul 21, 2024
5 checks passed
@paulverbeke paulverbeke mentioned this pull request Aug 21, 2024
Open
39 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@captn3m0 captn3m0 captn3m0 left review comments

@marcwrobel marcwrobel marcwrobel approved these changes

Assignees
No one assigned
Labels
new-product This PR adds a new product to the website.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paulverbeke @marcwrobel @captn3m0