Workflows: Download and cache Godot Engine for build#21
Merged
wjt merged 1 commit intoendlessm:mainfrom Jan 7, 2025
Merged
Conversation
cassidyjames
force-pushed
the
ci-improvements
branch
from
0ad6821 to
5cb7a06
Compare
Contributor
Author
|
For comparison
|
Rather than relying on downloading and executing in a third-party container, we can just grab Godot Engine and the export templates directly from the upstream release page. We cache these downloads so future runs have the binaries and templates (the latter of which are quite large) available right away for the run.
cassidyjames
force-pushed
the
ci-improvements
branch
from
5cb7a06 to
40d5ddd
Compare
wjt
approved these changes
Jan 7, 2025
Member
wjt
left a comment
wjt
left a comment
There was a problem hiding this comment.
LGTM.
It might be nice to wrap this up into a self-contained action – we'll otherwise need to copy this to 2+ other projects – but that could happen later.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rather than relying on downloading and executing in a third-party container, we can just grab Godot Engine and the export templates directly from the upstream release page.
We cache these downloads so future runs have the binaries and templates (the latter of which are quite large) available right away for the run.