Merged
Conversation
When running on a touchscreen, the (self-explanatory) controls are visible on-screen, and the assumption is that neither a keyboard nor a touchpad is available. So, hide the instructions in that case. If the player does have one or more joypads connected to their touchscreen device, they'll figure it out. There is no change notification for DisplayServer.is_touchscreen_available(). One might expect that its value could change: for example, only one of the screens currently connected to my computer. In fact, there are only 4 implementations: - The iOS and Android implementations always return true; - The web implementation checks whether window.ontouchstart is defined, which AFAICT cannot change; - The fallback implementation checks whether emulate_touch_from_mouse is set. So, it is safe to just check it once when the scene loads.
manuq
approved these changes
Dec 16, 2024
| Input.joy_connection_changed.connect(_on_joy_connection_changed) | ||
| # TODO: hide entirely if touch controls are visible? | ||
| if DisplayServer.is_touchscreen_available(): | ||
| %Start.hide() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running on a touchscreen, the (self-explanatory) controls are visible on-screen, and the assumption is that neither a keyboard nor a touchpad is available. So, hide the instructions in that case. If the player does have one or more joypads connected to their touchscreen device, they'll figure it out.
There is no change notification for DisplayServer.is_touchscreen_available(). One might expect that its value could change: for example, only one of the screens currently connected to my computer. In fact, there are only 4 implementations:
So, it is safe to just check it once when the scene loads.