Use mimalloc when targeting musl

Also removes the armv7 linux build. If you used it, let me know!
encounter · Sep 29, 2024 · 5ad514d · 5ad514d
1 parent 312dd6f
commit 5ad514d
Show file tree

Hide file tree

Showing 4 changed files with 29 additions and 5 deletions.
diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml
@@ -106,11 +106,6 @@ jobs:
             name: linux-aarch64
             build: zigbuild
             features: nightly
-          - platform: ubuntu-latest
-            target: armv7-unknown-linux-musleabi
-            name: linux-armv7l
-            build: zigbuild
-            features: default
           - platform: windows-latest
             target: i686-pc-windows-msvc
             name: windows-x86

diff --git a/Cargo.lock b/Cargo.lock
diff --git a/nodtool/Cargo.toml b/nodtool/Cargo.toml
@@ -43,6 +43,9 @@ xxhash-rust = { version = "0.8", features = ["xxh64"] }
 zerocopy = { version = "0.7", features = ["alloc", "derive"] }
 zstd = "0.13"
 
+[target.'cfg(target_env = "musl")'.dependencies]
+mimalloc = "0.1"
+
 [build-dependencies]
 hex = { version = "0.4", features = ["serde"] }
 quick-xml = { version = "0.36", features = ["serialize"] }

diff --git a/nodtool/src/main.rs b/nodtool/src/main.rs
@@ -1,5 +1,11 @@
 mod argp_version;
 
+// musl's allocator is very slow, so use mimalloc when targeting musl.
+// Otherwise, use the system allocator to avoid extra code size.
+#[cfg(target_env = "musl")]
+#[global_allocator]
+static ALLOC: mimalloc::MiMalloc = mimalloc::MiMalloc;
+
 use std::{env, error::Error, ffi::OsStr, fmt, path::PathBuf, str::FromStr};
 
 use argp::{FromArgValue, FromArgs};