Don't show objects as diffable in objdiff if a source file doesn't exist #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Works for me. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Somewhat recently in rb3 we filled in our objects list with every file in our splits.txt, so that we didn't have to put in file paths every time a new file was started, and so that we could re-enable
config.warn_missing_config. A side-effect of this is that objects in objdiff would always show as red/diffable, even when the corresponding source file is missing. This change fixes that, so that unstarted objects can be distinguished directly at a glance.This could also be done as a fix on objdiff's side of things, where it ignores the
completedmetadata if the specified source file doesn't exist, but that would require a lot of IO polling to check that on each config load, which could slow things somewhat notably.