Skip to content

Multiple Updates #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Sep 7, 2021
Merged

Multiple Updates #42

merged 8 commits into from
Sep 7, 2021

Conversation

npmccallum
Copy link
Member

@npmccallum
Clean up the TCS page implementation
0bd695d 
Signed-off-by: Nathaniel McCallum <[email protected]>
@npmccallum
Ensure the TCS page is page aligned and sized
030908f 
Signed-off-by: Nathaniel McCallum <[email protected]>
@npmccallum
Remove the unused TCS Flags type
d1775b6 
Signed-off-by: Nathaniel McCallum <[email protected]>
@npmccallum
Remove StateSaveArea::frame_size()
a4c0592 
This function doesn't make much sense.

Signed-off-by: Nathaniel McCallum <[email protected]>
@npmccallum
Make ExitType and Exception non-exhaustive
46b5933 
Signed-off-by: Nathaniel McCallum <[email protected]>
@npmccallum npmccallum requested a review from haraldh September 7, 2021 02:42
@npmccallum npmccallum mentioned this pull request Sep 7, 2021
Merged
haraldh
haraldh previously approved these changes Sep 7, 2021
View reviewed changes
Copy link
Member

@haraldh haraldh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@npmccallum
Bump for the latest primordial code
a0febc0 
Signed-off-by: Nathaniel McCallum <[email protected]>
@npmccallum
Drop the Tcs structure
53c160b 
This structure is mostly useless, except in trivial testing cases. We
therefore retain it in the enclave creation test. But it is no logner
public.

Signed-off-by: Nathaniel McCallum <[email protected]>
@npmccallum
Drop the StateSaveArea type
f17d762 
This type is highly implementation specific. Also, we will now rely on
types from the x86_64 crate.

Signed-off-by: Nathaniel McCallum <[email protected]>
@npmccallum npmccallum marked this pull request as ready for review September 7, 2021 16:55
@npmccallum npmccallum merged commit a0b881c into enarx:main Sep 7, 2021
@npmccallum npmccallum deleted the shim branch September 7, 2021 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haraldh haraldh haraldh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@npmccallum @haraldh