MODULARIZE / scriptDirectory improvements #6914
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nazar-pc
reviewed
Jul 27, 2018
tests/test_browser.py
Outdated
| ''') | ||
|
|
||
| self.run_browser('test-subdir.html', None, '/report_result?0') | ||
| for instance in (0, 1): |
There was a problem hiding this comment.
I'd rather make a list of tuples or something like that here. Looks hacky and takes more brain cycles to comprehend than necessary.
There was a problem hiding this comment.
Makes sense. I rewrote them that way, let me know what you think.
tests/test_browser.py
Outdated
| 'new Module();' | ||
| ): | ||
| print(creation) | ||
| for instance in (0, 1): |
There was a problem hiding this comment.
And the same idea here as above.
nazar-pc
approved these changes
Jul 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
new Module()(instead of justModule()) in finding the scriptDirectory. This is done by avoiding.bind(), and saving it in a closure. This seems like a potential common pitfall, so worth supporting even if it isn't the documented use (see Regression in modularize mode (currentSrc issue) #6903)._scriptDircode for MODULARIZE_INSTANCE - we only need it in MODULARIZE.emcc.pycode, do the extra scriptDirectory or instance stuff later, which I think is clearer.cc @nazar-pc