misc testing/CI tidy-up #6890
Merged
misc testing/CI tidy-up #6890
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hujiajie
force-pushed
the
testing
branch
2 times, most recently
from
1eb807f to
0b0a3ea
Compare
kripken
reviewed
Jul 23, 2018
| @@ -137,15 +141,21 @@ jobs: | |||
| test-browser: | |||
| <<: *test-defaults | |||
| environment: | |||
| # browser.test_sdl_ttf_render_text_solid depends on Arial from Microsoft | |||
| # browser.test_sdl2_mouse and/or SDL2 should be fixed. The case happens | |||
There was a problem hiding this comment.
the comments about test_sdl2_mouse and test_html5_webgl_create_context may have been removed by mistake, I think they are still needed?
.circleci/config.yml
Outdated
| # browser.test_webgl_offscreen_canvas_in_mainthread_after_pthread | ||
| # are crashing Firefox (bugzil.la/1281796). The former case even | ||
| # reveals more problems: 1) #4412 made it possible to keep threads | ||
| # alive for async functions, but the change got reverted by #5878; |
There was a problem hiding this comment.
please open an issue for the #5878 regression - I think maybe we just need to require NO_EXIT_RUNTIME be false when offscreen canvas, but we need to see. and please link to the issue you open here.
hujiajie
force-pushed
the
testing
branch
3 times, most recently
from
b090cf9 to
3610851
Compare
The logic has already been in tests/runner.py.
OffscreenCanvas is behind the gfx.offscreencanvas.enabled preference. The relevant tests are silently reported as ok if the feature is not enabled. Unfortunately, these tests are still skipped because of several bugs.
ttf-mscorefonts-installer allows for easy installation of the Microsoft True Type Core Fonts for the Web including Arial. The package requires acceptance of an EULA*. Informally speaking: These fonts were provided by Microsoft "in the interest of cross-platform compatibility". This is no longer the case, but they are still available from third parties. You are free to download these fonts and use them for your own use, but you may not redistribute them in modified form, including changes to the file name or packaging format. * http://corefonts.sourceforge.net/eula.htm
|
Great, thanks @hujiajie! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.