Less default runtime exports #5892
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…TIONS builds, a warning will be shown if they are used, using the mechanism we introduced for getValue/setValue which we recently removed from being exported by default
CDanU
added a commit
to CDanU/uncrustify
that referenced
this pull request
Dec 18, 2017
- adopt to changes in emscripten-core/emscripten#5892 - set the version to C++11 - update the interface itself
CDanU
added a commit
to CDanU/uncrustify
that referenced
this pull request
Dec 19, 2017
- adopt to changes in emscripten-core/emscripten#5892 - set the version to C++11 - update the interface itself
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More for #5836 (JS shrinking).
This removes almost all default function exports from the runtime. In ASSERTIONS builds, a warning will be shown if they are used, using the mechanism we introduced for getValue/setValue (which we recently removed from being exported by default).
This reduces the size of the #5836 testcase by almost 20% (!), shrinking us from 21.75 k to 17.65 k.
There are still a few things exported by default, like filesystem support (the file packager emits code that uses those, we should make extra sure this is not confusing for people) and things that aren't functions (need to investigate a good mechanism for warning if they are used incorrectly in ASSERTIONS mode, perhaps a getter on the Module object).
This PR also includes