-
Notifications
You must be signed in to change notification settings - Fork 3.4k
do not export getValue and setValue by default #5839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…SERTIONS that emits stubs that give an error message, so if a user depended on those being exported, in ASSERTIONS they get a clear error message
If I have a custom library file, will replacing Edit: no I see that it outputs code to directly access the HEAP array. Even better! |
Better than that, actually, it will still work without you doing anything :) We do still initially emit (That's true for a custom js library file, or any other code that gets optimized with the other JS. But if you use it from outside, you should be using I changed that one direct use of |
…ybeExport; just check if it exists already before exporting, don't override something
…tions. also split it up for convenience
Added some test fixes and improvements, and verified this passes all the tests locally, should be good to go. |
lgtm, I think this is exactly the direction we want to go, this will help developers explicitly make the choices what to include in. |
Thanks @juj. Before merging I'll mention this on the mailing list too for feedback. And I added a Changelog update for this as suggested by @curiousdannii in #5836 (comment) |
Just to be safe I waited for feedback an extra week after the lgtm here because this is the first of the breaking changes we've been discussing. Also discussion on the mailing list has been in support. Merging. |
Also add a mechanism in ASSERTIONS that emits stubs that give an error message, so if a user depended on those being exported, in ASSERTIONS they get a clear error message.