Skip to content
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions tools/ports/contrib/lua.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@

import os

TAG = '5.4.7'
HASH = '98c5c8978dfdf867e37e9eb3b3ec83dee92d199243b5119505da83895e33f10d43c841be6a7d3b106daba8a0b2bd25fe099ebff8f87831dcc55c79c78b97d8b8'
TAG = '5.5.0'
HASH = '3253d2cdc929da6438095a30d66ef16a1abdbb0ada8fee238705b3b38492f14be9553640fdca6b25661e01155ba5582032e0a2ef064e4c283e85efc0a128cabe'

# contrib port information (required)
URL = 'https://www.lua.org/'
Expand Down Expand Up @@ -36,9 +36,7 @@ def create(final):
ldblib.c liolib.c lmathlib.c loadlib.c loslib.c lstrlib.c ltablib.c lutf8lib.c linit.c
'''.split()

flags = ['-DLUA_COMPAT_5_3']
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This flag doesn't exist anymore so it's useless to leave it

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know why it was being used previously?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My understanding is that when they upgraded to 5.4 this flag was being used to still enable what was being deprecated/removed from 5.3. With the release of 5.5 it's truly removed so there's no way to reenable it, so the flag is gone. As I pointed out there is no such equivalent flag for 5.4


ports.build_port(source_path, final, port_name, srcs=srcs, flags=flags)
ports.build_port(source_path, final, port_name, srcs=srcs)

return [shared.cache.get_lib(lib_name, create, what='port')]

Expand Down