Skip to content

Add missing options to EmscriptenAudioWorkletNodeCreateOptions #25497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
+37 −4
Open

Add missing options to EmscriptenAudioWorkletNodeCreateOptions #25497

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
32ee9d9
fix: added missing options to EmscriptenAudioWorkletNodeCreateOptions
Oct 5, 2025
d9e8099
fix: updated channelCount, mode and interpretation with proper types …
Oct 6, 2025
9b5b7dc
added additional fields to struct for test cases
Oct 9, 2025
f9ad385
WIP pls work
Oct 9, 2025
2d676c5
I think im done now
Oct 9, 2025
8693ac7
this time fs
Oct 9, 2025
8a67632
nah bro istg this will work
Oct 9, 2025
1fd325d
life taught me lessons
Oct 9, 2025
675d07c
made the necessary modifications
Oct 18, 2025
b8ed668
corrections
Oct 18, 2025
0b47583
fixed formatting
Oct 21, 2025
c50281d
Merge branch 'main' into add_missing_options
nikitha-m Oct 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/lib/libwebaudio.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -318,6 +318,9 @@ var LibraryWebAudio = {
numberOfInputs: {{{ makeGetValue('options', C_STRUCTS.EmscriptenAudioWorkletNodeCreateOptions.numberOfInputs, 'i32') }}},
numberOfOutputs: optionsOutputs,
outputChannelCount: readChannelCountArray({{{ makeGetValue('options', C_STRUCTS.EmscriptenAudioWorkletNodeCreateOptions.outputChannelCounts, 'i32*') }}}, optionsOutputs),
channelCount: {{{ makeGetValue('options', C_STRUCTS.EmscriptenAudioWorkletNodeCreateOptions.channelCount, 'i32') }}},
channelCountMode: {{{ makeGetValue('options', C_STRUCTS.EmscriptenAudioWorkletNodeCreateOptions.channelCountMode, 'i32') }}},
channelInterpretation: {{{ makeGetValue('options', C_STRUCTS.EmscriptenAudioWorkletNodeCreateOptions.channelInterpretation, 'i32') }}},
processorOptions: {
callback,
userData,
Expand Down
5 changes: 5 additions & 0 deletions system/include/emscripten/webaudio.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,11 @@ typedef struct EmscriptenAudioWorkletNodeCreateOptions
int numberOfOutputs;
// For each output, specifies the number of audio channels (1=mono/2=stereo/etc.) for that output. Default=an array of ones for each output channel.
int *outputChannelCounts;
// Extended options from AudioWorkletNode
int channelCount;
int channelCountMode;
int channelInterpretation;

} EmscriptenAudioWorkletNodeCreateOptions;

// Instantiates the given AudioWorkletProcessor as an AudioWorkletNode, which continuously calls the specified processCallback() function on the browser's audio thread to perform audio processing.
Expand Down