Fix create_release.py script to handle bad underlines #24532
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
fix_create_release
branch
from
d02df50 to
199bc1d
Compare
dschuff
reviewed
Jun 9, 2025
The script was assuming the underline was the same length as the title itself. e.g. it did not handle. ``` 1.3.4 (in development) ------------------- ``` See emscripten-core#24516
sbc100
force-pushed
the
fix_create_release
branch
from
199bc1d to
c7ef13a
Compare
dschuff
approved these changes
Jun 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The script was assuming the underline was the same length as the title itself.
e.g. it did not handle.
See #24516