[embind] Remove ancient jshint comments. NFC #24520
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These comments were added together with Embind long, long time ago, but we don't use JSHint and our special library syntax wouldn't be compatible with it anyway, so the only thing they do is confuse devs who search for function usages.
sbc100
approved these changes
Jun 9, 2025
|
I don't even know what jshint is! |
|
JSHint what we had before ESLint, a tool by the same Douglas Crockford who created JSON. Long, long time ago now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These comments were added together with Embind long, long time ago, but we don't use JSHint and our special library syntax wouldn't be compatible with it anyway, so the only thing they do is confuse devs who search for function usages.