Skip to content

[contrib.glfw3] Use new external port feature #24518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 13, 2025

Conversation

ypujante
Copy link
Contributor

@ypujante ypujante commented Jun 7, 2025

Now that 4.0.10 has been released and contains the new feature to make a port external, I went ahead and applied it to contrib.glfw3. In the end I really like this model because it keeps all the implementation details of the port outside Emscripten. Incidentally it makes reading/parsing the port file faster and also reduces the size that gets shipped with Emscripten, especially if you never need the port...

@sbc100 sbc100 enabled auto-merge (squash) June 13, 2025 14:08
@ypujante
Copy link
Contributor Author

The only test failures after merging with main is:

======================================================================
FAIL [7.210s]: test_webgl_with_closure (test_browser.browser64_4gb)
----------------------------------------------------------------------

which is unrelated to my changes. The tests were all passing prior to the merge.

@sbc100 sbc100 disabled auto-merge June 13, 2025 16:58
@sbc100 sbc100 merged commit d281980 into emscripten-core:main Jun 13, 2025
28 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants