Skip to content

fix compilation of test/gl_in_mainthread_after_pthread.c #24511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

esqu1
Copy link

@esqu1 esqu1 commented Jun 6, 2025

The test was missing an Emscripten header so wasn't compiling. Should be working now!

Compiled with:

emcc gl_in_mainthread_after_pthread.c -o hello.html -pthread -sOFFSCREEN_FRAMEBUFFER 

@sbc100
Copy link
Collaborator

sbc100 commented Jun 6, 2025

Hmm, this test is currently disabled:

@requires_offscreen_canvas
@requires_graphics_hardware
@disabled('This test is disabled because current OffscreenCanvas does not allow transfering it after a rendering context has been created for it.')
def test_webgl_offscreen_canvas_in_mainthread_after_pthread(self, args):
self.btest('gl_in_mainthread_after_pthread.c', expected='0', emcc_args=args + ['-pthread', '-sPTHREAD_POOL_SIZE=2', '-sOFFSCREENCANVAS_SUPPORT', '-lGL'])
.

I wonder if we can get it working? If not its probably best just to delete it. How did you come across this test BTW?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants