Fix test_emsize under windows. NFC - #24439
Merged
Merged
Conversation
sbc100
force-pushed
the
test_emsize_windows
branch
from
May 29, 2025 23:05
1e08a27 to
60335e4
Compare
dschuff
approved these changes
May 30, 2025
Split out from emscripten-core#24437
sbc100
force-pushed
the
test_emsize_windows
branch
from
May 30, 2025 15:54
60335e4 to
2e0e84f
Compare
Collaborator
|
Great. I observe on my Windows box that pulling to branch that has this fix does not unfortunately yet fix the issue, but the test Running performs a re-checkout of the file, and after that the test starts to pass. Thought that's ok I think. |
Lukasdoe
pushed a commit
to Lukasdoe/emscripten
that referenced
this pull request
Jun 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split out from #24437