Skip to content

Attempt to fix some windows-specific test failures. NFC #24437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −4
Open

Attempt to fix some windows-specific test failures. NFC #24437

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions test/test_core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6130,7 +6130,7 @@ def test_unistd_links(self):
self.do_run_in_out_file_test('unistd/links.c')

@also_with_noderawfs
@no_windows('TODO: Fails on Windows due to an unknown reason.')
@crossplatform
def test_unistd_write_broken_link(self):
self.do_run_in_out_file_test('unistd/test_unistd_write_broken_link.c')

Expand Down Expand Up @@ -8271,7 +8271,7 @@ def test_asyncify_unused(self):
'onlylist_b_response': ([], True, 'main\n__original_main\nfoo(int, double)\nbaz()\nc_baz\nStructy::funcy()\n'),
'onlylist_c_response': ([], False, 'main\n__original_main\nfoo(int, double)\nbaz()\nc_baz\n'),
})
@no_windows("TODO: Fails on Windows due to an unknown reason.")
@crossplatform
def test_asyncify_lists(self, args, should_pass, response=None):
if response is not None:
create_file('response.file', response)
Expand Down
4 changes: 2 additions & 2 deletions test/test_other.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -825,7 +825,7 @@ def test_em_config_filename(self):
self.assertContained('LLVM', proc.stdout)
self.assertContained('filename myconfig.py', proc.stdout)

@no_windows('This test depends on Linux line endings')
@crossplatform
def test_emsize(self):
# test binaryen generated by running:
# emcc test/hello_world.c -Oz --closure 1 -o test/other/test_emsize.js
Expand Down Expand Up @@ -1759,7 +1759,7 @@ def test_ungetc_fscanf(self):
self.emcc('main.c', ['--embed-file', 'my_test.input'], output_filename='a.out.js')
self.assertContained('zyx', self.run_process(config.JS_ENGINES[0] + ['a.out.js'], stdout=PIPE, stderr=PIPE).stdout)

@no_windows('This test is written to work on Linux and macOS only')
@crossplatform
def test_abspaths(self):
# Includes with absolute paths are generally dangerous, things like -I/usr/.. will get to system
# local headers, not our portable ones.
Expand Down