Simplify EGL/GLFW/SDL/GLUT/Browser canvas access. NFC #23614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All of these frameworks still use `Module['canvas']`. This change simplifies and unifies the access to the canvas to single helper function.
sbc100
changed the title
sbc100
changed the title
kripken
reviewed
Feb 6, 2025
We don't have codesize tests for any of these frameworks, but I imagine it can only be positive since it avoid duplicating the string |
|
For browser.test_sdl_alloctext I see a tiny regression from 157890 to 157905 bytes of JS (0.09%) |
|
For |
kripken
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All of these frameworks still use
Module['canvas']. This change simplifies and unifies the access to the canvas to single helper function per library.As a followup we may want to extend this to all use of
Module['canvas'].