Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inject minimal_runtime_exit_handling.js as part of also_with_minimal_runtime. NFC #23559

Merged
merged 1 commit into from
Jan 31, 2025

Conversation

sbc100
Copy link
Collaborator

@sbc100 sbc100 commented Jan 31, 2025

This allows also_with_minimal_runtime to be used in more places removing a bunch of duplication.

@sbc100 sbc100 changed the title Inject minimal_runtime_exit_handling.js as part of `also_with_minim… Inject minimal_runtime_exit_handling.js as part of also_with_minimal_runtime. NFC Jan 31, 2025
@sbc100 sbc100 requested a review from brendandahl January 31, 2025 19:20
@sbc100 sbc100 force-pushed the also_with_minimal_runtime branch from a44231a to ff4ee13 Compare January 31, 2025 19:21
test/test_core.py Outdated Show resolved Hide resolved
@sbc100 sbc100 force-pushed the also_with_minimal_runtime branch from ff4ee13 to 80eb9e6 Compare January 31, 2025 21:32
@sbc100 sbc100 requested a review from brendandahl January 31, 2025 21:34
…al_runtime`. NFC

This allows `also_with_minimal_runtime` to be used in more places
removing a bunch of duplication.
@sbc100 sbc100 force-pushed the also_with_minimal_runtime branch from 80eb9e6 to c1b2a42 Compare January 31, 2025 21:37
@sbc100 sbc100 merged commit f7475a8 into emscripten-core:main Jan 31, 2025
29 checks passed
@sbc100 sbc100 deleted the also_with_minimal_runtime branch January 31, 2025 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants