Skip to content

Commit

Permalink
Address review
Browse files Browse the repository at this point in the history
  • Loading branch information
juj committed Nov 29, 2023
1 parent 6621213 commit 6f96eae
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion ChangeLog.md
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ See docs/process.md for more on how version tagging works.
from later enabling "dormant" features if WebGL implementations gain new
WebGL extensions in the future. (#20802)
- Breaking change: Using the `*glGetProcAddress()` family of functions now
requires passing a linker flag -sGL_ENABLE_GET_PROC_ADDRESS=1. This prevents
requires passing a linker flag -sGL_ENABLE_GET_PROC_ADDRESS. This prevents
ports of native GL renderers from later accidentally attempting to activate
"dormant" features if web browser implementations gain new WebGL extensions in
the future. (#20802)
Expand Down
2 changes: 1 addition & 1 deletion emcc.py
Original file line number Diff line number Diff line change
Expand Up @@ -937,7 +937,7 @@ def phase_setup(options, state, newargs):

# SDL2 requires eglGetProcAddress() to work.
# NOTE: if SDL2 is updated to not rely on eglGetProcAddress(), this can be removed
if settings.USE_SDL == 2 or settings.USE_SDL_MIXER == 2 or settings.USE_SDL_GFX == 2:
if settings.USE_SDL == 2:
default_setting('GL_ENABLE_GET_PROC_ADDRESS', 1)

return (newargs, input_files)
Expand Down

0 comments on commit 6f96eae

Please sign in to comment.