fix dialyzer failures. #244
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thank you @jimsynz |
|
@zmstone I'm not sure that it's possible. |
-if(?OTP_RELEASE < 27). |
|
Aha! This is why we don't get Elixirists to write Erlang :) I'll update the PR. |
jimsynz
force-pushed
the
fix-dialyzer-warnings
branch
from
09b1ee1 to
670641b
Compare
|
@zmstone good to go for your review. Cheers! |
zmstone
reviewed
Jul 4, 2024
| @@ -33,7 +33,7 @@ | |||
|
|
|||
| -type(sockname() :: {inet:ip_address(), inet:port_number()}). | |||
|
|
|||
| -type(option() :: gen_tcp:connect_option() | {ssl_opts, [ssl:ssl_option()]}). | |||
| -type(option() :: gen_tcp:connect_option() | {ssl_opts, [ssl:tls_option()]}). | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there.
Running dialyzer on an Elixir project which has
emqttas a dependency results in the following dialyzer failures:The SSL one is easy to fix - there is no
ssl:ssl_option(or at least not anymore), but there isssl:tls_option.The other failure is because the
emqx_typesmodule doesn't exist. I found it inside theemqxapp source, butemqxis not listed as a project dependency. I'm open to suggestions on how to fix that.