Fix uploading coverage to coveralls#52
Open
MasterOdin wants to merge 1 commit into
Open
Conversation
Signed-off-by: Matthew Peveler <matt.peveler@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR attempts to fix uploading to coveralls for the repo by switching from the third-party npm package for coveralls to the first-party GHA coveralls action.
The npm package has long been abandoned, and that using it with GHA requires you to generate a token on coveralls, add it as a secret here, and then pass it in as an environment variable. The action on the other hand is supported, and shouldn't require any configuration in regards to tokens and should just work out of the box.
From the action, it looks like the job was successfully uploaded to coveralls: https://coveralls.io/builds/73905020