Skip to content

Conversation

@bircni
Copy link
Contributor

@bircni bircni commented Dec 14, 2025

Continuement of #76

@github-actions
Copy link

View snapshot changes at kitdiff

@bircni
Copy link
Contributor Author

bircni commented Jan 11, 2026

Hi @kitizz, thanks for the detailed review—here are the follow-ups:

  • examples/userdata_points/src/app.rs: I scrapped the Arc<Mutex<HashMap<Id, …>>> dance and now pre-populate an
    egui::IdMap keyed by the item ids before calling Plot::show. The formatter no longer relies on show() executing first,
    the item argument is now Some((Id, index)) when hovering actual plot points, and None otherwise (so the item argument
    can reliably be used just like you suggested).
  • egui_plot/src/label.rs + egui_plot/src/plot.rs: Added docs describing that the third formatter argument carries the
    hovered item‘s (Id, index) when available and is None for empty space. The example also names that argument so it’s
    clear how to format the final tooltip text.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant