-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Serialize window maximized state in WindowSettings
#5554
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code LGTM
Preview available at https://egui-pr-preview.github.io/pr/5554-restorewindowmaximizedstate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately, this leads to a deadlock on Mac when running cargo run -p custom_window_frame
See also #3612
Will take a look to see if I can resolve the deadlock. |
cf9d63b
to
2d5aeb2
Compare
Left a comment in #3494 and also created rust-windowing/winit#4071. For now I've removed the erroneous unconditional |
A user of my Windows application reported a papercut where the application restores its size on next load, but does not restore its maximized state. This PR fixes that.
To test, I patched https://github.com/emilk/eframe_template to use my local code since I knew that template saves/restores window data. Testing methodology was to simply
cargo run
, maximize the application, then close the application.cargo run
again and the application should start maximized.Closes #1517.
./scripts/check.sh
for some reason. Possibly a bad Python version?