test: add coverage for picture_profile feature#51
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
The
picture_profilefeature (upload, resize, JPEG conversion, placeholder,auto-creation via signal) had no test coverage. This adds it and along the
way the tests exposed a real bug with transparent PNGs.
What
Added 5 tests in
tests/test_user_profile.py:resize_imageshrinks large images to 400px widthconvert_type_imageproduces a real JPEG (checks actual format, not just filename)UserProfileis auto-created via signal when aUseris createdAlso added
tests/helpers.pywith a reusablecreate_test_imagehelper.Bug fix included
The RGBA test revealed that
convert_type_imagecrashed on transparent images(
cannot write mode RGBA as JPEG), since JPEG has no alpha channel. Fixed byconverting any non-RGB image to RGB before saving as JPEG. This would have
broken in production for any user uploading a PNG with transparency.
How to verify
pytest tests/test_user_profile.py -v— all 5 pass. Full suite stays green.Closes #39