feat: add default avatar placeholder for profiles without picture#50
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
UserProfilehad no fallback when a user has no picture since the API returnednull. This completes issue #35 by serving a default avatar.
What
picture_profileSerializerMethodField that returns the user's photoURL, or a static placeholder when none exists
static/images/placeholder.jpgas the default avatarSTATICFILES_DIRSso the project's static folder is collectedWhy
The placeholder is a static asset (served by WhiteNoise) rather than stored in
the DB or pulled from an external service — keeps the field empty when there's
no upload, and the default is decided at response time. Easy to swap later
without a migration.
How to verify
GET /api/auth/me/for a user without a picture returnspicture_profile: "/static/images/placeholder.jpg". Tested via curl with JWT.Closes #35