fix: serve static files in production via deploy.sh#48
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
In production (DEBUG=False) Django doesn't serve static files automatically.
The DRF browsable API and admin were rendering without CSS. WhiteNoise was
already configured (middleware + storage), but
collectstaticwas never run.What
deploy.shscript that runscollectstaticbefore starting gunicorn${PORT}so the bind works both on Railway (injected PORT) and locallystaticfiles/directory in gitWhy
Static collection must happen at container start, not build time, because the
production settings require environment variables that only exist at runtime.
Running it in
deploy.sh(withset -eto fail fast, andexecfor propersignal handling) keeps the startup sequence explicit and easy to extend.
How it works
deploy.sh:set -e→collectstatic --noinput→exec gunicornCompressedManifestStaticFilesStorage)How to verify
Tested locally simulating production (DEBUG=False, gunicorn via the script):
the DRF browsable API renders with CSS. After merge, confirm the same at
api.simlog.app.br/api/auth/register/.