New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify some tests by setting `parserOptions` globally instead of in each individual test case #570

Merged

bmish merged 1 commit into ember-cli:master from bmish:test-simplify-parserOptions

Nov 6, 2019

Member

bmish commented Nov 6, 2019 •

edited

Loading

Significantly simplifies many test files and improves readability. This allows many valid test cases to be strings instead of objects.

If all individual test cases in a file specify the same parserOptions, then parserOptions should be set globally instead.

Relevant:

bmish added the internal label


          test: simplify some tests by setting parserOptions globally instead…

982c217

… of in each individual test case

Significantly simplifies many test files and improves readability. This allows many valid test cases to be strings instead of objects.

If all individual test cases in a file specify the same `parserOptions`, then `parserOptions` should be set globally instead.

Relevant: https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/blob/master/docs/rules/test-case-shorthand-strings.md

bmish merged commit 4416ac3 into ember-cli:master

bmish mentioned this pull request

Simplify tests for no-restricted-resolver-tests rule by using global parserOptions #613

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels