Skip to content

Conversation

@igordayen
Copy link
Contributor

@igordayen igordayen commented Nov 10, 2025

Overview

please refer to PR: embabel/embabel-common#86

Current PR should be executed after abovementioned PR merger.

Jackson converters do not have dependency on agent API and can be re-used elsewhere in embabel eco-system.

Moved Jackson convertors from embabel-agent repo to repo embalel-common:

Copy to embabel-common

  # In embabel-common
  mkdir -p
  embabel-common-ai/src/main/kotlin/com/embabel/common/ai/converters
  mkdir -p
  embabel-common-ai/src/test/kotlin/com/embabel/common/ai/converters

  # Copy files
  cp embabel-agent/embabel-agent-api/src/main/kotlin/com/embabel/agent/spi/
  support/springai/JacksonOutputConverter.kt \
     embabel-common-ai/src/main/kotlin/com/embabel/common/ai/converters/

  cp embabel-agent/embabel-agent-api/src/main/kotlin/com/embabel/agent/spi/
  support/springai/FilteringJacksonOutputConverter.kt \
     embabel-common-ai/src/main/kotlin/com/embabel/common/ai/converters/

  cp embabel-agent/embabel-agent-api/src/test/kotlin/com/embabel/agent/spi/
  support/springai/FilteringJacksonOutputConverterTest.kt \
     embabel-common-ai/src/test/kotlin/com/embabel/common/ai/converters/

  # Update FilteringJacksonOutputConverter import to use common package
  # Build & test embabel-common

Updated import in

embabel-agent-api/src/main/kotlin/com/embabel/agent/spi/support/springai/ChatClientLlmOperations.kt

@sonarqubecloud
Copy link

@alexheifetz alexheifetz merged commit 62e0971 into main Nov 11, 2025
8 of 12 checks passed
@alexheifetz alexheifetz deleted the jackson-converters-refactoring branch November 11, 2025 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants