notmuch: fix RET keybinding in notmuch-hello-mode.
#820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the previous version, pressing "RET" (i.e., calling `evil-collection-notmuch-hello-ret`) on a recent search to enter a search mode buffer, then pressing `q` to quit the search buffer and return to the hello buffer, would result in all evil state keybindings in `notmuch-hello-mode-map` being deactivated. Rewriting the `evil-collection-notmuch-hello-ret` function resolves this issue.
|
I don't know why the CI on ubuntu yield the following compile error: I didn't modify |
|
Be patient. I will review this patch after purcell/setup-emacs#49 fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the previous version, pressing "RET" (i.e., calling
evil-collection-notmuch-hello-ret) on a recent searches to enter a search mode buffer, then pressingqto quit the search buffer and return to the hello buffer, would result in all evil state keybindings innotmuch-hello-mode-mapbeing deactivated. Rewriting theevil-collection-notmuch-hello-retfunction resolves this issue.