Designer embedded activity select fix #514
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated `GetFlowchart` method in `ActivityExtensions.cs` to handle various activity types, including a new fallback for synthetic flowcharts. Modified `VisitAndMapAsync` in `ActivityVisitorExtensions.cs` to prevent node duplication. Improved `LoadFlowchartAsync` in `FlowchartDesignerWrapper.razor.cs` to unwrap flowcharts and optimize loading by checking for previously loaded charts. Updated using directives to include necessary namespaces.
- Updated `GetFlowchart` to return a nullable `JsonObject?` and added `FindActivitiesContainer` for better activity container retrieval. - Refactored `LoadFlowchartAsync` in `FlowchartDesigner.razor.cs` to utilize the new method, improving flowchart loading flexibility. - Added `CreateSyntheticContainer` helper to wrap single activities in an activities array. - Enhanced `AutoLayoutAsync` to check for null flowcharts before processing. - Modified flowchart unwrapping logic in `FlowchartDesignerWrapper.razor.cs` to support both flowcharts and activities containers. - Improved robustness in `InvokeDesignerActionAsync` with a null check for the action parameter. - Refactored `SelectActivityAsync` in `DiagramDesignerWrapper.razor.cs` to use an activity node lookup dictionary for more efficient activity selection.
…ub.com/MaxBrooks114/elsa-studio into MethodNotSupportedOnJournalEntrySelect
…to MethodNotSupportedOnJournalEntrySelect
Refactor code for better readability by adding line breaks and consistent indentation. Reformat properties marked with the `[Parameter]` attribute without changing functionality. Service injections are now listed on separate lines for clarity. Adjustments made to method logic for improved clarity in conditional checks and assignments. These changes enhance maintainability while preserving existing functionality.
sfmskywalker
previously approved these changes
May 16, 2025
Member
sfmskywalker
left a comment
sfmskywalker
left a comment
There was a problem hiding this comment.
Looks like some parts have been merged already by your previous PR. Let mek now if you need help fixing the merge conflicts 👍🏻
KnibbsyMan
reviewed
Oct 5, 2025
src/modules/Elsa.Studio.Workflows.Core/Extensions/ActivityExtensions.cs
Outdated
Show resolved
Hide resolved
sfmskywalker
force-pushed
the
main
branch
2 times, most recently
from
a948a9e to
0e54668
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.