-
Notifications
You must be signed in to change notification settings - Fork 30
[BUG] Fix SQLite dependency in PersistenceFeatureBase #50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: sfmskywalker <[email protected]>
|
@Copilot please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement ( “Agreement” ) is agreed to by the party signing below ( “You” ), 1. Definitions. “Code” means the computer software code, whether in human-readable or machine-executable form, “Project” means any of the projects owned or managed by .NET Foundation and offered under a license “Submit” is the act of uploading, submitting, transmitting, or distributing code or other content to any “Submission” means the Code and any other copyrightable material Submitted by You, including any 2. Your Submission. You must agree to the terms of this Agreement before making a Submission to any 3. Originality of Work. You represent that each of Your Submissions is entirely Your 4. Your Employer. References to “employer” in this Agreement include Your employer or anyone else 5. Licenses. a. Copyright License. You grant .NET Foundation, and those who receive the Submission directly b. Patent License. You grant .NET Foundation, and those who receive the Submission directly or c. Other Rights Reserved. Each party reserves all rights not expressly granted in this Agreement. 6. Representations and Warranties. You represent that You are legally entitled to grant the above 7. Notice to .NET Foundation. You agree to notify .NET Foundation in writing of any facts or 8. Information about Submissions. You agree that contributions to Projects and information about 9. Governing Law/Jurisdiction. This Agreement is governed by the laws of the State of Washington, and 10. Entire Agreement/Assignment. This Agreement is the entire agreement between the parties, and .NET Foundation dedicates this Contribution License Agreement to the public domain according to the Creative Commons CC0 1. |
03f07db to
5722b06
Compare
Problem
When using a custom persistence feature with SQL Server, the following error occurs:
This happens because the SQLite provider's
SetupForSqlitehandler is unconditionally registered in the service collection even when using a different database provider, causing conflicts with other database providers like SQL Server.Solution
The fix changes how the SQLite-specific handler registration is managed:
SetupForSqlitehandler from theUseSqliteextension methodSetupForSqliteclass to register the handler in a more controlled wayNow when using SQL Server without SQLite, the SQLite-specific handler won't be automatically registered, preventing the provider conflict.
Notes
SetupForSqlitehandler itself already had appropriate checks to only execute SQLite-specific code when the database is actually SQLiteFixes #49.
Warning
Firewall rules blocked me from connecting to one or more addresses
I tried to connect to the following addresses, but was blocked by firewall rules:
crl3.digicert.com/usr/lib/dotnet/dotnet exec /usr/lib/dotnet/sdk/8.0.115/NuGet.CommandLine.XPlat.dll package add --package Microsoft.EntityFrameworkCore --project /tmp/test-elsa/test-elsa.csproj --version 8.0.0 --dg-file /tmp/tmpcLUqBs.tmp(dns block)ocsp.digicert.com/usr/lib/dotnet/dotnet exec /usr/lib/dotnet/sdk/8.0.115/NuGet.CommandLine.XPlat.dll package add --package Microsoft.EntityFrameworkCore --project /tmp/test-elsa/test-elsa.csproj --version 8.0.0 --dg-file /tmp/tmpcLUqBs.tmp(dns block)If you need me to access, download, or install something from one of these locations, you can either:
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.