Skip to content

Replace FluentMigrator.Runner meta-package with FluentMigrator.Runner.Core #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Copilot wants to merge 4 commits into
base: main
Choose a base branch
from
+26 −25
Open

Replace FluentMigrator.Runner meta-package with FluentMigrator.Runner.Core #113

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b379ae4
Initial plan
Copilot Jan 9, 2026
cfe9b71
Replace FluentMigrator.Runner with FluentMigrator.Runner.Core
Copilot Jan 9, 2026
2b80470
Refactor to reduce code duplication in migration configuration
Copilot Jan 9, 2026
bc5016c
Address PR review comments: remove return statement and add XML docs
Copilot Jan 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions Directory.Packages.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,6 +151,9 @@
<PackageVersion Include="FastEndpoints.Swagger" Version="7.1.1"/>
<PackageVersion Include="FluentMigrator" Version="7.2.0"/>
<PackageVersion Include="FluentMigrator.Runner" Version="7.2.0"/>
<PackageVersion Include="FluentMigrator.Runner.Core" Version="7.2.0"/>
<PackageVersion Include="FluentMigrator.Runner.SqlServer" Version="7.2.0"/>
<PackageVersion Include="FluentMigrator.Runner.SQLite" Version="7.2.0"/>
<PackageVersion Include="FluentStorage" Version="6.0.0"/>
<PackageVersion Include="Fluid.Core" Version="2.31.0"/>
<PackageVersion Include="Fody" Version="6.9.3"/>
Expand Down
4 changes: 2 additions & 2 deletions src/modules/persistence/Elsa.Persistence.Dapper/Elsa.Persistence.Dapper.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,11 @@
<PackageReference Include="Azure.Identity"/>
<PackageReference Include="Dapper"/>
<PackageReference Include="FluentMigrator"/>
<PackageReference Include="FluentMigrator.Runner"/>
<PackageReference Include="FluentMigrator.Runner.Core"/>
<PackageReference Include="Microsoft.Data.Sqlite.Core"/>
<PackageReference Include="Microsoft.Data.SqlClient"/>
<PackageReference Include="Microsoft.Identity.Client"/>
<PackageReference Include="Npgsql"/>
<PackageReference Include="System.Data.SqlClient"/>
<PackageReference Include="System.Formats.Asn1"/>
</ItemGroup>

Expand Down
18 changes: 0 additions & 18 deletions src/modules/persistence/Elsa.Persistence.Dapper/Features/DapperMigrationsFeature.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,24 +14,6 @@ namespace Elsa.Persistence.Dapper.Features;
/// </summary>
public class DapperMigrationsFeature(IModule module) : FeatureBase(module)
{
/// <summary>
/// Configures migrations to use SQLite.
/// </summary>
public DapperMigrationsFeature UseSqlite()
{
ConfigureRunner += runner => runner.AddSQLite();
return this;
}

/// <summary>
/// Configures migrations to use SQLite.
/// </summary>
public DapperMigrationsFeature UseSqlServer()
{
ConfigureRunner += runner => runner.AddSqlServer();
return this;
}

/// <summary>
/// Gets or sets a delegate to configure migrations.
/// </summary>
Expand Down
2 changes: 2 additions & 0 deletions src/workbench/Elsa.Server.Web/Elsa.Server.Web.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,8 @@
<PackageReference Include="Elsa.Workflows.Api" />
<PackageReference Include="Elsa.WorkflowProviders.BlobStorage" />
<PackageReference Include="Elsa.Workflows.Runtime.Distributed" />
<PackageReference Include="FluentMigrator.Runner.SqlServer" />
<PackageReference Include="FluentMigrator.Runner.SQLite" />
<PackageReference Include="Hangfire.Core" />
<PackageReference Include="Hangfire.MemoryStorage" />
<PackageReference Include="Hangfire.PostgreSql" />
Expand Down
16 changes: 12 additions & 4 deletions src/workbench/Elsa.Server.Web/Program.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
using Elsa.Identity.Multitenancy;
using Elsa.OpenTelemetry.Middleware;
using Elsa.Persistence.Dapper.Extensions;
using Elsa.Persistence.Dapper.Contracts;
using Elsa.Persistence.Dapper.Services;
using Elsa.Persistence.EFCore.Extensions;
using Elsa.Persistence.EFCore.Modules.Alterations;
Expand Down Expand Up @@ -53,6 +54,7 @@
using Elsa.Workflows.Runtime.Options;
using Elsa.Workflows.Runtime.Stores;
using Elsa.Workflows.Runtime.Tasks;
using FluentMigrator.Runner;
using Hangfire;
using Hangfire.MemoryStorage;
using Hangfire.PostgreSql;
Expand Down Expand Up @@ -128,10 +130,16 @@
{
dapper.UseMigrations(feature =>
{
if (sqlDatabaseProvider == SqlDatabaseProvider.SqlServer)
feature.UseSqlServer();
else
feature.UseSqlite();
feature.ConfigureRunner = builder =>
{
var runnerBuilder = sqlDatabaseProvider == SqlDatabaseProvider.SqlServer
? builder.AddSqlServer()
: builder.AddSQLite();

return runnerBuilder
.WithGlobalConnectionString(sp => sp.GetRequiredService<IDbConnectionProvider>().GetConnectionString())
.WithMigrationsIn(typeof(Elsa.Persistence.Dapper.Migrations.Management.Initial).Assembly);
};
});
dapper.DbConnectionProvider = sp =>
{
Expand Down
Loading