Pull request for master branch #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous approach had some assumptions (e.g., it assumed there was a singe instance of the editor on the same page) that lead to some bugs and corner cases. Now the plugin hooks on the form submit event and clean the highlighting <span> tags there. The cleaning doesn't use any regexes any longer. Instead it uses DOM operations that are more robust and potentially faster. Also multilang tag highlighting <span>'s are now removed/added when switching to/from HTML view, reducing clutter when editing the HTML code. Some initial coding style cleanup work has been carried out. More to follow. Tested in Firefox 56 and Chromium 61.0.3163.100. Closes eljulians#2 eljulians#18 eljulians#21
IE doesn't implement Function.caller.name (it's not part of the standard), so we directly use the function from the HTML view plugin object for the comparison. Tested with Internet Explorer 11.0.9600.18762 in Windows 7 SP1, and Firefox 56 and Chromium 61.0.3163.100 in Linux. Also fix CSS bug introduced in a previous commit (missing ';' at the end of the property).
And make sure we don't include in the repo the Node modules used by Grunt.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes proposed in this pull request fixes some of the outstanding bugs. Besides that, multilang tag highlighting 's are now removed/added when switching to/from HTML view, reducing clutter when editing the HTML code.
It also adds all the Grunt support files for linting and minification, and lots of PHPDocs to the code and have lots of changes to make it compliant with the Moodle coding and documentation guidelines.
Closes #2 #18 #21