add prefix option to RequestId #1293
Closed
+26
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Schultzer
force-pushed
the
add-prefix-option-to-request-id
branch
from
d37a37c to
e1a9723
Compare
Member
|
Instead of a prefix, it probably makes more sense to allow a &fun/0 to be passed that generates the ID. And then we expose ours and you can build whatever you want on top. |
Member
|
Closing in favor of #1294. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a prefix option to Plug.RequestId, in a micro service architecture it can be helpful to append prefix to request id that a service generate them self, to differentiate them from all other request.