Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows maps to encode domain keys, from paper https://www.irif.fr/~gc/papers/icfp23.pdf
For example, we can now express the type
%{a: integer(), b: float(), atom() => tuple()}
of maps that have keys:a
and:b
and any other atom key mapping to a tuple.Those are created by adding {{:domain_key, :atom}, type} pairs to constructors open_map or closed_map.
This introduces new operators:
map[key]
where key is some expression of some typeMap.put(map, key, type)
(not called map_put because the name is already used for adding a single key to a map. The difference here is that,key
being a type, we are not sure which key is being added).Both operators handle singleton atoms exactly. See the following tests:
Notes:
map_check_domain_keys(tag, neg_tag)
is very long to treat all the different cases optimally. It could be shortened to a single loop on all the possible domains, with default values.