-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: migrate to TS #37
base: master
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Reviewer's Guide by SourceryThis pull request implements a significant migration from JavaScript to TypeScript, along with a shift from Create React App to Vite as the build tool. The changes include updating the project structure, configuration files, and core application files to support TypeScript and Vite. The PR also introduces new styling approaches and removes several components, indicating a major refactoring of the application architecture. File-Level Changes
Tips
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @dhararaghu777 - I've reviewed your changes - here's some feedback:
Overall Comments:
- This is a significant change that removes a lot of existing functionality. Could you provide more details on your migration strategy and how you plan to reimplement the removed features in the new TypeScript environment?
- The move to TypeScript and Vite is promising for improved developer productivity and code quality. However, please ensure that all critical features (e.g., workflow management, user authentication) are preserved or have a clear plan for reimplementation.
- Consider a more gradual migration approach to minimize disruption to users and contributors. This could involve migrating components one by one rather than replacing the entire codebase at once.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟡 Documentation: 1 issue found
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
dd9616a
to
f297dbd
Compare
f297dbd
to
ec9b7b0
Compare
IMPORTANT: Please create an issue before filing a pull request! Changes need to be discussed before proceeding. Please read the contribution guidelines.
Details
Please provide enough information so that others can review your pull request. Give a brief summary of the motivation. Refer to the corresponding issue/s with
#XXXX
for more information.Testing
Write the appropriate unit and integration tests, if applicable. Make sure these and all other tests pass.
Documentation
Please document your changes and test cases in the appropriate places, if applicable.
Style
Make sure your changes adhere to the coding/documentation style used throughout the project.
Closing issues
If your changes fix any issue/s, put
closes #XXXX
in your comment to auto-close it/them.Summary by Sourcery
Migrate the project to a new setup using React, TypeScript, and Vite, replacing the existing Krini application. Update the ESLint configuration to support TypeScript and React, and revise the README to reflect these changes. Remove obsolete components and configuration files related to the previous setup.
New Features:
Enhancements:
Documentation: