-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tes): add struct #37
Conversation
Reviewer's Guide by SourceryThis pull request introduces the TES (Task Execution Service) struct and its associated functionality. The main changes are in File-Level Changes
Tips
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @aaravm - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider improving error handling consistency across functions. Some return Box while others return String. A uniform approach would enhance maintainability.
- The
ensure_funnel_running()
function in test_utils.rs relies on grepping process output, which could be fragile. Consider a more robust method for checking if the service is running.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all good! a couple of minor highlights:
-
the sample task definition file
grape.tes
implies a template engine that changes credential placeholders with some values on the SDK side before sending it to TES. it's not implemented in the SDK at the moment, but the file itself is generally valid as a sample. -
I don't know why
lib/src/clients/tes/model.rs
wasn't in PR35 with other TES models. A comment would be helpful, maybe there where problems with model autogeneration.
Good points. Would be good to add notes about these in the PR description. Otherwise, I think it's good to go. |
This PR contains the TES struct in
lib/src/tes/mod.rs
and a corresponding needed model definition inlib/src/tes/model.rs
.Tests
folder just contains some sample .tes files.Notes:
Summary by Sourcery
Add TES struct with task management methods and corresponding unit tests.
New Features:
Tests: