-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add .tool-versions
#37
base: main
Are you sure you want to change the base?
Conversation
Reviewer's Guide by SourceryThis pull request introduces a Sequence diagram for asdf-install Makefile target executionsequenceDiagram
participant User
participant Make
participant Shell
participant ToolVersions
User->>Make: make asdf-install (or make asdfi)
Make->>ToolVersions: Read .tool-versions file
ToolVersions-->>Make: Return installation commands
Make->>Shell: Execute installation commands
Shell-->>Make: Return execution status
Make-->>User: Installation complete
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @JaeAeich - I've reviewed your changes - here's some feedback:
Overall Comments:
- The
.tool-versions
file appears to be empty. Please add the required tool version specifications to make this change functional.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
@sourcery-ai review |
@sourcery-ai summary |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @JaeAeich - I've reviewed your changes - here's some feedback:
Overall Comments:
- The .tool-versions file appears to be empty in the diff. Please include its intended contents so we can review the tool specifications.
- Consider adding documentation about the expected format and usage of the '# INSTALL:' commands in .tool-versions, since this is a custom implementation.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Description
.tool-versions
#27Checklist
project, including, in particular, with regard to any style guidelines
specification; in particular, it clearly indicates
that a change is a breaking change
using the PR title as the commit message
changed behavior
or updated existing ones (only for Python, TypeScript, etc.)
docstrings) for all packages/modules/functions/classes/
methods or updated existing ones
works
Comments
Summary by Sourcery
Build:
asdf-install
to install tools specified in.tool-versions
.