Skip to content

Commit

Permalink
Removes trans from longitude scales
Browse files Browse the repository at this point in the history
  • Loading branch information
eliocamp committed Jan 9, 2025
1 parent 1c3d2c3 commit ccc5c77
Show file tree
Hide file tree
Showing 5 changed files with 11 additions and 11 deletions.
9 changes: 7 additions & 2 deletions NEWS.md
Original file line number Diff line number Diff line change
@@ -1,12 +1,17 @@
# metR (development version)

## Bug fixes

- Longitude scales now properly pass the `trans`/`transform` argument.

# metR 0.16.0

## New features

- `EOF()`'s `rotate` argument now will take a function to apply to the EOF loadings. `rotate = TRUE` is still supported but deprecated and will default to using `function(x) stats::varimax(x, normalize = FALSE)`.
- `EOF()`'s `rotate` argument now will take a function to apply to the EOF loadings.
`rotate = TRUE` is still supported but deprecated and will default to using `function(x) stats::varimax(x, normalize = FALSE)`.

- Contour functions gain a `proj.latlon` to decide if the projection needs to go to latlon coordinates or to projected coordinates.
- Contour functions gain a `proj.latlon` to decide if the projection needs to go to latlon coordinates or to projected coordinates.

## Breaking changes

Expand Down
3 changes: 0 additions & 3 deletions R/scale_longitude.R
Original file line number Diff line number Diff line change
Expand Up @@ -36,13 +36,11 @@ scale_x_longitude <- function(name = "", ticks = 30,
breaks = seq(-180, 360, by = ticks),
expand = c(0, 0),
labels = LonLabel,
trans = "identity",
...) {
# labels = waiver()
ggplot2::scale_x_continuous(name = name, expand = expand,
breaks = breaks,
labels = labels,
trans = trans,
...)
}

Expand All @@ -52,7 +50,6 @@ scale_y_longitude <- function(name = "", ticks = 60,
breaks = seq(-180, 360, by = ticks),
expand = c(0, 0),
labels = LonLabel,
trans = "identity",
...) {
ggplot2::scale_y_continuous(name = name, expand = expand,
breaks = breaks,
Expand Down
3 changes: 1 addition & 2 deletions man/metR.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 2 additions & 4 deletions man/scale_longitude.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions metR.Rproj
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
Version: 1.0
ProjectId: d63f6cba-48e1-4dfb-b6a9-368776a989fe

RestoreWorkspace: No
SaveWorkspace: No
Expand Down

0 comments on commit ccc5c77

Please sign in to comment.