Array.prototype.sort compareFunction expects a number to be returned. - #24
Open
dgalvez wants to merge 1 commit into
Open
Array.prototype.sort compareFunction expects a number to be returned.#24dgalvez wants to merge 1 commit into
dgalvez wants to merge 1 commit into
Conversation
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/sort This was causing a buggy behaviour when variable names were substrings of other variable names. Example: JSON.stringify(["hola", "holab", "ho"].sort( ( x, y ) => false )) === JSON.stringify(["hola", "holab", "ho"].sort( ( x, y ) => true ))
rqman
added a commit
to mw-team/cross-let
that referenced
this pull request
Sep 25, 2023
rqman
added a commit
to mw-team/cross-let
that referenced
this pull request
Sep 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/sort
This was causing a buggy behaviour when variable names were substrings of other variable names.
Example:
JSON.stringify(["hola", "holab", "ho"].sort( ( x, y ) => false )) === JSON.stringify(["hola", "holab", "ho"].sort( ( x, y ) => true ))